Skip to content

Add src folder to package.json files field#312

Open
vafanassieff wants to merge 1 commit into
flightcontrolhq:mainfrom
vafanassieff:main
Open

Add src folder to package.json files field#312
vafanassieff wants to merge 1 commit into
flightcontrolhq:mainfrom
vafanassieff:main

Conversation

@vafanassieff

Copy link
Copy Markdown

Hey, it seems you are building with source maps, but you are missing the src folder in the files field from package.json.

Best

@vafanassieff vafanassieff requested a review from Skn0tt as a code owner January 17, 2025 09:29
@Skn0tt

Skn0tt commented Jan 17, 2025

Copy link
Copy Markdown
Collaborator

I'm not sure we're building with sourcemaps on purpose. How did you stumble across this? Would source maps and source files have helped you to debug something?

@vafanassieff

vafanassieff commented Jan 17, 2025

Copy link
Copy Markdown
Author

I updated vitest to 3.0.1 and vite to 6.0.7, and I got a warning when running tests on my frontend app.

Sourcemap for "node_modules/.pnpm/superjson@2.2.2/node_modules/superjson/dist/index.js" points to missing source files

Source maps are useful if you want your IDE to go to typescript files instead of the dist folder.

I got this warning and just wanted to remove it, for clarity’s sake.
If you don't ship src folder, you don't need to build with source maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants